From bef106d127abd12cae53dffdc9a4f98ed9906226 Mon Sep 17 00:00:00 2001 From: Steven Agyekum Date: Thu, 8 Jun 2023 17:23:41 +0200 Subject: [PATCH 1/4] validate remote_path is not empty --- entrypoint.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/entrypoint.sh b/entrypoint.sh index 9d0f2b5..8b437e7 100755 --- a/entrypoint.sh +++ b/entrypoint.sh @@ -1,5 +1,10 @@ #!/bin/sh +if [ -z "$(awk '{$1=$1};1' <<< "$INPUT_REMOTE_PATH")" ]; then + echo "The remote_path can not be empty. see: github.com/Burnett01/rsync-deployments/issues/44" + exit 1 +fi + # Start the SSH agent and load key. source agent-start "$GITHUB_ACTION" echo "$INPUT_REMOTE_KEY" | SSH_PASS="$INPUT_REMOTE_KEY_PASS" agent-add From 570fd6bb52b116bc20b41c36c1a5b6d487552750 Mon Sep 17 00:00:00 2001 From: Steven Agyekum Date: Thu, 8 Jun 2023 17:27:31 +0200 Subject: [PATCH 2/4] fix empty string check --- entrypoint.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/entrypoint.sh b/entrypoint.sh index 8b437e7..c40ca1f 100755 --- a/entrypoint.sh +++ b/entrypoint.sh @@ -1,6 +1,6 @@ #!/bin/sh -if [ -z "$(awk '{$1=$1};1' <<< "$INPUT_REMOTE_PATH")" ]; then +if [ -z "$(awk '{$1=$1} END{print}' <<< "$INPUT_REMOTE_PATH")" ]; then echo "The remote_path can not be empty. see: github.com/Burnett01/rsync-deployments/issues/44" exit 1 fi From d732b3973265878780ccda490964c163ad73ab63 Mon Sep 17 00:00:00 2001 From: Steven Agyekum Date: Thu, 8 Jun 2023 17:35:29 +0200 Subject: [PATCH 3/4] improved string empty check for remote_path --- entrypoint.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/entrypoint.sh b/entrypoint.sh index c40ca1f..2ff103a 100755 --- a/entrypoint.sh +++ b/entrypoint.sh @@ -1,6 +1,6 @@ #!/bin/sh -if [ -z "$(awk '{$1=$1} END{print}' <<< "$INPUT_REMOTE_PATH")" ]; then +if [ -z "$(echo "$INPUT_REMOTE_PATH" | awk '{$1=$1};1')" ]; then echo "The remote_path can not be empty. see: github.com/Burnett01/rsync-deployments/issues/44" exit 1 fi From 45d84ad5f6c174f3e0ffc50e9060a9666d09c16e Mon Sep 17 00:00:00 2001 From: Steven Agyekum Date: Thu, 8 Jun 2023 17:54:10 +0200 Subject: [PATCH 4/4] New version 6.0.0 - It is no longer possible to use an empty string as remote_path (Fixes #44) (Thanks to @maximilliangeorge) - Updated checkout action in examples from v2 to v3 - Added disclaimer to media site-links - Overall readme improvements --- README.md | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index fd82a1d..e0aeae9 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ This GitHub Action (amd64) deploys files in `GITHUB_WORKSPACE` to a remote folde Use this action in a CD workflow which leaves deployable code in `GITHUB_WORKSPACE`. -The base-image (drinternet/rsync) of this action is very small and is based on Alpine 3.17.2 (no cache) which results in fast deployments. +The base-image [drinternet/rsync](https://github.com/JoshPiper/rsync-docker/) of this action is very small and is based on Alpine 3.17.2 (no cache) which results in fast deployments. --- @@ -53,9 +53,9 @@ jobs: deploy: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: rsync deployments - uses: burnett01/rsync-deployments@5.2.2 + uses: burnett01/rsync-deployments@6.0.0 with: switches: -avzr --delete path: src/ @@ -72,9 +72,9 @@ jobs: deploy: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: rsync deployments - uses: burnett01/rsync-deployments@5.2.2 + uses: burnett01/rsync-deployments@6.0.0 with: switches: -avzr --delete --exclude="" --include="" --filter="" path: src/ @@ -92,9 +92,9 @@ jobs: deploy: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: rsync deployments - uses: burnett01/rsync-deployments@5.2.2 + uses: burnett01/rsync-deployments@6.0.0 with: switches: -avzr --delete path: src/ @@ -112,9 +112,9 @@ jobs: deploy: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: rsync deployments - uses: burnett01/rsync-deployments@5.2.2 + uses: burnett01/rsync-deployments@6.0.0 with: switches: -avzr --delete path: src/ @@ -184,6 +184,8 @@ Please note that version 1.0 has reached end of life state. This action was featured in multiple blogs across the globe: +> Disclaimer: The author & co-authors are not responsible for the content of the site-links below. + - https://leobrack.co.uk/blog/2020-02-15-automatically-push-changes-to-your-live-site-with-github-actions - https://blog.maniak.co/ci-cd-for-wordpress/